98.css icon indicating copy to clipboard operation
98.css copied to clipboard

Implement menu bar and menu for windows

Open kodie opened this issue 2 years ago • 9 comments

I added a menu bar and menus for windows. It might not be 100% but I think it's pretty damn close. 😃

In addition to the menu bar I also added a frame class for the window-body class to get smaller margins.

Screenshots: Screen Shot 2023-04-28 at 9 41 45 AM Screen Shot 2023-04-28 at 9 43 29 AM

Reference screenshot from Windows 98: Screen Shot 2023-04-28 at 9 42 37 AM

kodie avatar Apr 28 '23 14:04 kodie

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 2:53pm

vercel[bot] avatar Apr 28 '23 14:04 vercel[bot]

Somewhat related: https://github.com/jdan/98.css/issues/38

kodie avatar Apr 28 '23 14:04 kodie

I guess maybe the menu bar could have been its own component to be consistent with how it's done on win7.css? https://khang-nd.github.io/7.css/#menubar

idk let me know what you think, I can change it if needed.

kodie avatar Apr 28 '23 15:04 kodie

Also the frame class I added could become the default and we could implement a has-space class to add the margin back like how win7.css does it: https://khang-nd.github.io/7.css/#window-body

kodie avatar Apr 28 '23 15:04 kodie

This looks very good. I think that ideally the menu should open and then close on repeated clicks. Maybe a <details> element could work for that, but we'd have to check if we can make it look like a menu bar item.

chanagaray avatar Sep 21 '23 18:09 chanagaray

Make menu have multi-level capability as some menu items may have parent-child relationship

ippezshelby avatar Sep 27 '23 13:09 ippezshelby

sorry i might be really stupid but for some reason i cant get the menu buttons to actually do anything? im trying to use onclick which is what i use for my other buttons. am i missing something?

you can see my project for reference at https://909.wtf/

edit: using onmousedown works

909oce avatar Feb 24 '24 20:02 909oce

When will this be merged?

ammaraslam10 avatar Jul 06 '24 16:07 ammaraslam10