98.css icon indicating copy to clipboard operation
98.css copied to clipboard

Input type="number" arrows overflow off the input

Open chanagaray opened this issue 2 years ago • 6 comments

In this deploy, it looks like this:

image

Whereas on main it looks like this

image

chanagaray avatar Mar 29 '23 16:03 chanagaray

main is "bad", 9c190beb0a19597c215c9ea8c2e4613ef5604ec2 is good. Bisecting... (edit: none of those commits was good)

chanagaray avatar Sep 21 '23 19:09 chanagaray

The first bad commit has my name on it ( 735b3c600658dd598afc193de85b437df1d50528 )

image

chanagaray avatar Sep 21 '23 19:09 chanagaray

No, wait! There aren't any actual good commits in the main branch. Which is very weird. But the results of git blame are invalid.

chanagaray avatar Sep 22 '23 14:09 chanagaray

Nothing interesting there. But maybe the implementation of the border changed.

chanagaray avatar Sep 22 '23 15:09 chanagaray

Oops! The Good commit was from a PR I closed! https://github.com/jdan/98.css/pull/154

chanagaray avatar Sep 25 '23 18:09 chanagaray

MWUE has Spin Boxes which illustrate how these arrows should look. See p. 184, figure 8.32

chanagaray avatar Oct 08 '23 18:10 chanagaray