John-David Dalton

Results 381 comments of John-David Dalton

> In this workaround, why do we use Electron, not just the browsers? To me, the browser still has many restrictions to access local files, watch the file change and...

Hi @hguiney! Let's take care of that over on [the issue tracker](https://github.com/standard-things/esm/issues). I have a hunch at the root cause. I'll fix that right up. **Update:** Fixed in [v3.0.83](https://github.com/standard-things/esm/releases/tag/3.0.83) :tada:

I'll check and report/back close as necessary. **Update:** Ok, so it's still an issue. I'll look into it. **Update:** We can fix this with a `Reflect` distortion.

Right now because of our proxy traps for `defineProperty`, `set`, `deleteProperty` some `Reflect` method calls for `Reflect.deleteProperty`, `Reflect.defineProperty`, `Reflect.set` will throw instead of returning `false`. The distortion would be to...

> Attempted to set a non-object key in a WeakMap That comes from an assumption in our code that an API exists that doesn't and we're trying to use an...

Okay on the shared state. I'll figure out another way to do that. _(likely exposed property on global that is plucked and removed)_

Much more of it works!! Things are in a more working state. I think we can start reverting debug stuff and making this more like what the final result will...

Hmm I must have been seeing things. Still some work to do to get tests passing with ShadowRealm.

Hi @Jack-Works! By exotic objects do you mean proxied objects?