gitbeaker icon indicating copy to clipboard operation
gitbeaker copied to clipboard

Allow MR discussions to be resolved

Open sandercox opened this issue 2 years ago • 5 comments

While at the same time fixing the fact that discussion ids issued from my gitlab instance are hex-strings and not just 'numbers' as stated in their documentation.

Filed an issue with gitlab too for that: https://gitlab.com/gitlab-org/gitlab/-/issues/358951

sandercox avatar Apr 21 '22 06:04 sandercox

Just to avoid doubling the work, ill pull these changes into the new release branch. Ill probably have to cherry pick the commits, but they will be included!

jdalrymple avatar Apr 26 '22 13:04 jdalrymple

This was a two part fix, number -> string

but also added a method to resolve a merge request discussion. Either this was already in your branch but I didn't see that in your commit. Just to be sure that gets merged too!

sandercox avatar Apr 26 '22 18:04 sandercox

This was a two part fix, number -> string

but also added a method to resolve a merge request discussion. Either this was already in your branch but I didn't see that in your commit. Just to be sure that gets merged too!

I already had it in the branch haha, just slow on the release. Testing is taking ages

jdalrymple avatar Apr 26 '22 23:04 jdalrymple

@jdalrymple any timeframe on release... not being a js/ts developer by profession gives me a super hard time trying to build something that depends on my changes so anxiously awaiting a release ;-)

sandercox avatar May 19 '22 11:05 sandercox

@sandercox Sorry for the delay, just have alot going on. Currently dont have a fixed time for the release unfortunately :(

jdalrymple avatar Jul 13 '22 03:07 jdalrymple

:rocket: Issue was released in 37.0.0 :rocket:

jdalrymple avatar Apr 26 '23 17:04 jdalrymple