gitbeaker icon indicating copy to clipboard operation
gitbeaker copied to clipboard

Users.current() should return UserExtendedSchema

Open 10ko opened this issue 3 years ago • 2 comments

Description

I would expect the Users.current() function to return UserExtendedSchema as opposed to the current return type UserSchema. Is this expected?

Steps to reproduce

Just trying to use the Users.current() function should show the issue.

Expected behaviour

I would expect the return type to be Promise<UserExtendedSchema | undefined>

Actual behaviour

Users.current() returns Promise<UserSchema>

Possible fixes

I am no expert of this codebase but it looks like it would be as easy as changing the type in here. I can make a PR if that's what's needed. 🌻

10ko avatar Sep 16 '21 20:09 10ko

This is gonna wait until i fix #1897

jdalrymple avatar Sep 18 '21 15:09 jdalrymple

Gotcha, thanks for taking a look!

10ko avatar Sep 20 '21 09:09 10ko

:rocket: Issue was released in 37.0.0 :rocket:

jdalrymple avatar Apr 26 '23 17:04 jdalrymple