routeros-api-go icon indicating copy to clipboard operation
routeros-api-go copied to clipboard

Published 20 hours ago • verified publisher icon jda

Separate package for reading Mikrotik sentences

Open andre-luiz-dos-santos opened this issue 8 years ago • 2 comments

andre-luiz-dos-santos avatar Jul 13 '16 15:07 andre-luiz-dos-santos

I have committed this to github.com/go-routeros/routeros. Suggestions are welcome.

andre-luiz-dos-santos avatar Jul 21 '16 18:07 andre-luiz-dos-santos

Thanks for the PR! The reader/writer implementation looks quite promising.

I'm having a bit of trouble untangling this as the pr has a lot of commits with quite a few seemingly unrelated issues. Perhaps this could be split into a PR per functional change? Some of the changes (e.g. removing the New(address) constructor) break the documentation (usage example in README). In cases like that, it would be nice to see the documentation updated alongside the commit.

Also, it looks like some import statements from dev env leaked over, "joi.com.br/mikrotik-go/proto"?

jda avatar Aug 08 '16 21:08 jda