tenacity icon indicating copy to clipboard operation
tenacity copied to clipboard
verified publisher icon jd

Support async actions

Open hasier opened this issue 1 year ago • 2 comments

Fixes #249 #412

Second PR after breaking down https://github.com/jd/tenacity/pull/433 (follows https://github.com/jd/tenacity/pull/434)

  • First PR https://github.com/jd/tenacity/pull/434
  • Third PR https://github.com/hasier/tenacity/pull/2

After DRYing the iter() function, make AsyncRetrying support async callbacks.

Supersedes https://github.com/hasier/tenacity/pull/1

hasier avatar Feb 06 '24 11:02 hasier

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

mergify[bot] avatar Feb 06 '24 11:02 mergify[bot]

@jd any more thoughts on this? Happy to clarify anything else I may have missed.

hasier avatar Feb 13 '24 09:02 hasier

@jd I merged changes from main and tests seem to pass, feel free to re-approve and merge whenever you prefer 🙂

hasier avatar Feb 26 '24 09:02 hasier

@jd now that this is merged, do you think it's ready to be released in a new version? Or would you rather see some async strategies merged first too? ~The only issue I see with that is how we'd solve sync+async combinations 🤔~ Gave a go at fixing the sync+async issue and it seems to be working, let me know what you think! https://github.com/jd/tenacity/pull/451

hasier avatar Mar 18 '24 15:03 hasier