Feature/badge

[apodacaduron]

Hi, today i worked on a Badge component to wrap other elements, hope you like it. Did my best to try to follow the current standards but feel free to change anything

[netlify[bot]]

✅ Deploy Preview for anu-vue ready!

Name	Link
🔨 Latest commit	918eb4d17491745c8c08a22c226a7d3fe64ec0c2
🔍 Latest deploy log	https://app.netlify.com/sites/anu-vue/deploys/6340b7b2232ef50008fe608d
😎 Deploy Preview	https://deploy-preview-6--anu-vue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[jd-solanki]

Hi 👋🏻

Thanks for PR. This is huge ❤️

I really loved the idea of the max prop. This is really useful.

I have a few changes if you don't mind correcting them.

Please let me know if you need any help, I will be there for you.

[apodacaduron]

Hey thanks for your detailed feedback completely agree, will get this done soon as I'm on vacation at the moment. Talk to you soon

[apodacaduron]

Hey i did some updates based on your feedback hopefully it's better

However about this one i am not sure what it is yet 🤔

Do you have any idea why a-badge-wrapper have extra space when we compare it to it's child?

e.g. In the default demo, the icon have 24x24 and a-badge-wrapper have 24x30 🤔

Adding display: flex does solve the issue but it might affect the content

[jd-solanki]

Hi, Thanks for taking the time to update the code.

Sorry I was busy with the list component lately. I will start reviewing it tomorrow.

I hope you enjoyed your vacation 🏖️

[jd-solanki]

Hi @apodacaduron

There's good news for you 😇

If we merge #16 you can omit writing inline-block in every i tag class 🎊

[jd-solanki]

Hi @apodacaduron

I reviewed the PR and everything is exactly how it should be ❤️

I have introduced the new bordered prop and overlap's default value is true now.

Moreover, I have fetched the latest code update from the main branch.

The last thing I need help with is that we introduced bordered prop which breaks the dot prop UI.

Can you help me fix that?

Thanks 😇

[jd-solanki]

I will also update the badge.md when I get time according to this issue: #17

[apodacaduron]

Will take a look at that prop soon

[jd-solanki]

Hi @apodacaduron

We are planning to make v0.10.0 one of the major releases. We are at v0.9.0 now. Can we have a badge in v0.10.0?

[apodacaduron]

Hi thank you for your patience, i replaced the border with an outline, this way the badge will preserve the same dimensions and won't affect the dot variant :)

[jd-solanki]

Awesome ❤️