DeepFactors icon indicating copy to clipboard operation
DeepFactors copied to clipboard

Build Issue with cmake 3.20.5

Open lkskstlr opened this issue 2 years ago • 0 comments

Hi @jczarnowski,

thank you for this nice open-source project! Working with the code was a pleasure so far!

I just tried to build the dependencies (./makedeps.sh) with cmake 3.20.5 and it doesn't build with this error

CMake Error: Unknown argument -Eigen_DIR=/some/dir/I/removed

I think this is a cmake bug that is reported here: https://gitlab.kitware.com/cmake/cmake/-/issues/22060. Additionally, I built the project on the same machine with cmake 3.19 and all goes well.

Maybe you could add an if clause that removes the -- -j${num_threads} part from line 30 if num_threads=1

  ${CMAKE} --build ${builddir} --target install -- -j${num_threads} || exit

or add a comment for cmake 3.20 users until this bug is fixed.

Cheers Lukas

lkskstlr avatar Aug 22 '21 09:08 lkskstlr