Peribot icon indicating copy to clipboard operation
Peribot copied to clipboard

Meme music

Open AnActualEmerald opened this issue 4 years ago • 3 comments

This works surprisingly well, so assuming peribot's house can handle whatever fairly limited processing it requires I think it would make for a neat feature. All it does is add a 15 second clip from some meme-able audio (currently Your Best Nightmare from undertale and Giorno's theme) to whatever image is supplied. The output is currently a webm which seems to work much better than the mp4s I tried earlier for whatever reason. The biggest issue I can see with this command is the potential for abuse by people sending massive files, but it wouldn't be too hard to implement a file size restriction of some sort.

AnActualEmerald avatar Feb 18 '21 06:02 AnActualEmerald

I am new to movie.py but it looks like you need to free up the files after they are used See here

Also I think enforcing a resolution constraint on the output would be a good idea See Here

jcsumlin avatar Feb 18 '21 17:02 jcsumlin

Ah that makes sense, I'll add that when I get a chance

AnActualEmerald avatar Feb 18 '21 18:02 AnActualEmerald

I added a limit so the command will only accept files less than 1MB in size, which is pretty easily changed if you still think that's too high. The output resolution isn't currently being set as the videos that are being made already look pretty compressed compared to the input, and if the input is limited to a reasonable size then it shouldn't be an issue I think.

AnActualEmerald avatar Feb 19 '21 18:02 AnActualEmerald