Josh Stein

Results 269 comments of Josh Stein

will this PR make it possible to generate the spec json file on releases? to be stored as artifacts on the release as suggested in https://github.com/celestiaorg/celestia-node/issues/2611?

> ![imagefromabove](https://private-user-images.githubusercontent.com/40579846/323650247-8046b8c7-b53a-40ef-b160-8087f80eeb98.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM1MzkxNzYsIm5iZiI6MTcxMzUzODg3NiwicGF0aCI6Ii80MDU3OTg0Ni8zMjM2NTAyNDctODA0NmI4YzctYjUzYS00MGVmLWIxNjAtODA4N2Y4MGVlYjk4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE5VDE1MDExNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWExMDk4MmYyYzZlY2RhNjdmNDQzNWVkZjM2ZWZlMGVhNDAzMmNjNjkyZjgyMDdhZmMwZjYxMzU5MjUzNzA0NmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.K0A6pjNKnjdWF07G_3XFvE6avw9PEdAl2_wi1FckT14) it looks like this just outputs the version info? but not the actual api specs? am i missing something here?

**flagging that I do not think this PR should be merged**. it (1) makes it impossible to generate rpc docs, which is counterproductive (2) introduces `celestia docgen` which outputs the...

> will this PR make it possible to generate the spec json file on releases? to be stored as artifacts on the release as suggested in https://github.com/celestiaorg/celestia-node/issues/2611? thank you, and...

it works for me. but why do we need 2 commands to generate the spec? shouldn't `celestia docgen` handle this for us? also, [in the output I get when testing...

I understand that. I'm trying to understand if it helps accomplish that goal, or of it is going to add more work, that is all

my only feedback would be that the `celestia docgen` command is a little misleading, as it doesn't actually generate the docs. the command to do that is `make openrpc-gen` which...

I still do not think an empty value should return an error, as it is not an error. There is just no share at that namespace and that height.

So @SuperFluffy in this case, at _least_ `foo`'s blob should be returned, and it appears that no blob for `bar` results in an error when querying `[foo, bar]`?