osara icon indicating copy to clipboard operation
osara copied to clipboard

Provide feedback for Envelope: Increase/decrease bezier tension for selected points actions

Open Batworx opened this issue 1 year ago • 8 comments

So we can cycle through five of the available point shapes. Square, linear, fast start, fast end, and slow start/end. Is there a particular reason for not including the bezier shape?

Batworx avatar Oct 05 '23 09:10 Batworx

Is bezier useful without being able to set bezier tension (which you have to do from the dialog)?

jcsteh avatar Oct 05 '23 10:10 jcsteh

I'm not sure about other folks, but I've used bezier without having to change the tension before. It sounds slightly different to linear.

Batworx avatar Oct 05 '23 10:10 Batworx

I just wanted to point out in this regard that I use two actions to change the shape of the envelope point directly, so that a point automatically becomes shape-changeable using these actions: Envelope: Increase bezier tension for selected points by 5% and to decrease it Envelope: Decrease bezier tension for selected points by 5% this means that I can change the shapes of the points on the fly without problems.

ranetto avatar Oct 05 '23 10:10 ranetto

Adding the bezier shape to this command is a trivial change, as long as it's actually useful/usable (since it does mean one more key press to cycle through the list). @ScottChesworth , any thoughts?

jcsteh avatar Oct 06 '23 05:10 jcsteh

Bezier at default tension is different to linear, but not markedly different, so I'm gonna label it low priority. For the change to be really useful, I think we'd need to provide feedback when adjusting tension via actions: Envelope: Decrease bezier tension for selected points by 5% (41123) Envelope: Increase bezier tension for selected points by 5% (41122) Envelope: Decrease bezier tension for selected points by 25% (41125) Envelope: Increase bezier tension for selected points by 25% (41124)

ScottChesworth avatar Oct 06 '23 19:10 ScottChesworth

If I understand https://github.com/jcsteh/osara/issues/939#issuecomment-1748628268 correctly, changing the bezier tension with those actions automatically sets the shape to bezier. If that's the case, we don't need to include bezier in the cycle action, since it's reasonable to require tweaking bezier tension in order to use bezier.

jcsteh avatar Oct 07 '23 07:10 jcsteh

Ah yeah, I missed that Detail, tested just now and that is indeed how it works. Is feedback for those actions possible?

ScottChesworth avatar Oct 07 '23 11:10 ScottChesworth

I believe so. Tension does seem to be exposed in the API.

jcsteh avatar Oct 07 '23 12:10 jcsteh