osara
osara copied to clipboard
jcsteh
Set muteNextMessage to false before returning when calling handleToggleCommand
Build succeeded! Build osara pr915-1151,442f5345 completed (commit https://github.com/jcsteh/osara/commit/442f53454a by @ScottChesworth) Downloads:
@jennykbrennan, can you see whether this fixes mute next message action on Mac?
@RDMurray, false before returning cleans up speech on Mac, but breaks the intended behaviour on Windows. It still worked fine to mute OSARA toggles here, but when I made a custom action with our mute next message then a REAPER toggle I still got the full report. Any idea why this is behaving differently on each platform?
Both with the main OSARA and with Scott's adjusted versions I get the following behaviour:
I have a custom action mapped to ctrl-shift-m that calls Osara mute next and Toggle track FX announcement.
When I run it by the keystroke, it is silent - but then my next action (such as moving to a different track) is muted.
However, the FX announcement is not toggled.
Tim
On 9 Jul 2023, at 7:34 pm, ScottChesworth @.***> wrote:
@jennykbrennan https://github.com/jennykbrennan, can you see whether this fixes mute next message action on Mac?
— Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/pull/915#issuecomment-1627660688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNKY26XLRJLTMVYDFXXMDDXPJ3KDANCNFSM6AAAAAA2DMHMHI. You are receiving this because you are subscribed to this thread.
@TimNoonanVoice I think that's another bug unrelated to muting.
@ScottChesworth I haven't worked out what's going on with mac yet, But I've installed Reaper for mac and I should get to it today.
@TimNoonanVoice, can you try triggering that OSARA toggle from a keystroke without the mute action involved? I'd like to get confirmation that it works reliably on its own.
I suspect it's a problem with calling osara actions from custom actions. Does the problem of the toggle not working only happen on mac?
Hi all,
Should have done that earlier.
Can confirm that after removing the mute action, the toggle fx status does not seem to work on Mac.
Tim
On 10 Jul 2023, at 8:57 pm, ScottChesworth @.***> wrote:
@TimNoonanVoice https://github.com/TimNoonanVoice, can you try triggering that OSARA toggle from a keystroke without the mute action involved? I'd like to get confirmation that it works reliably on its own.
— Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/pull/915#issuecomment-1628712739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNKY23XTOI2CWT6I23RSTDXPPNZ7ANCNFSM6AAAAAA2DMHMHI. You are receiving this because you were mentioned.
