osara
osara copied to clipboard
jcsteh
Add a "Report full time for time movement commands" configuration option.
Fixes #613.
@ptorpey, @Ambro86, could you test a build from here and let me know if this works for you?
Build succeeded! Build osara pr752-959,1749df37 completed (commit https://github.com/jcsteh/osara/commit/1749df379f by @jcsteh) Downloads:
This is going to need a complete refactor to handle item/envelope point navigation.
Assuming this builds successfully, this is ready for another round of testing. This now reports full times for item navigation, envelope point movement, etc. if appropriate. I've also refactored the time formatting code so future code can easily benefit from this setting. There are still cases where we force caching or force no caching; e.g. reporting selection never caches, while second and subsequent presses of item edge movement commands always cache (since you're presumably pressing them rapidly at that point and have sufficient context from the previous press).
Build succeeded! Build osara pr752-998,e47460a6 completed (commit https://github.com/jcsteh/osara/commit/e47460a6a0 by @jcsteh) Downloads:
Hi, thanks, but this exe file is seen as a virus by windows defender. Why didn't this happen in previous builds?
2022-08-24 13:51 GMT+02:00, AppVeyorBot @.***>:
Build succeeded! Build osara pr752-998,e47460a6 completed (commit https://github.com/jcsteh/osara/commit/e47460a6a0 by @jcsteh) Downloads:
-- Reply to this email directly or view it on GitHub: https://github.com/jcsteh/osara/pull/752#issuecomment-1225613206 You are receiving this because you were mentioned.
Message ID: @.***>
Unfortunately, that happens semi-regularly. OSARA installers aren't Authenticode signed, so it's hit and miss as to whether Defender likes them or not. I can tell you that these are built on a service which uses clean virtual machines for each build, so there's pretty much 0 chance there is a virus.
Looks good on Windows. Thanks for addressing this. Very nice.
--Pete
From: James Teh @.> Sent: Wednesday, August 24, 2022 5:49 AM To: jcsteh/osara @.> Cc: ptorpey @.>; Mention @.> Subject: Re: [jcsteh/osara] Add a "Report full time for time movement commands" configuration option. (PR #752)
Assuming this builds successfully, this is ready for another round of testing. This now reports full times for item navigation, envelope point movement, etc. if appropriate. I've also refactored the time formatting code so future code can easily benefit from this setting. There are still cases where we force caching or force no caching; e.g. reporting selection always forces caching, while second and subsequent presses of item edge movement commands always cache (since you're presumably pressing them rapidly at that point and have sufficient context from the previous press).
— Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/pull/752#issuecomment-1225610820 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJO7GC5OWXRMPF5HXUTV2YD3BANCNFSM5UZVZWYA . You are receiving this because you were mentioned.Message ID: @.***>
I've tried it on Windows and is all ok! Thanks!
2022-08-24 19:34 GMT+02:00, ptorpey @.***>:
Looks good on Windows. Thanks for addressing this. Very nice.
--Pete
From: James Teh @.***>
Sent: Wednesday, August 24, 2022 5:49 AM
To: jcsteh/osara @.***>
Cc: ptorpey @.>; Mention @.>
Subject: Re: [jcsteh/osara] Add a "Report full time for time movement commands" configuration option. (PR #752)
Assuming this builds successfully, this is ready for another round of testing. This now reports full times for item navigation, envelope point movement, etc. if appropriate. I've also refactored the time formatting code so future code can easily benefit from this setting. There are still cases where we force caching or force no caching; e.g. reporting selection always forces caching, while second and subsequent presses of item edge movement commands always cache (since you're presumably pressing them rapidly at that point and have sufficient context from the previous press).
—
Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/pull/752#issuecomment-1225610820 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJO7GC5OWXRMPF5HXUTV2YD3BANCNFSM5UZVZWYA .
You are receiving this because you were mentioned.Message ID: @.***>
--
Reply to this email directly or view it on GitHub:
https://github.com/jcsteh/osara/pull/752#issuecomment-1226032023
You are receiving this because you were mentioned.
Message ID: @.***>
The new time setting Seems to work correctly on Mac as well.
thanks
On 24 Aug 2022, at 9:49 pm, James Teh @.***> wrote:
Assuming this builds successfully, this is ready for another round of testing. This now reports full times for item navigation, envelope point movement, etc. if appropriate. I've also refactored the time formatting code so future code can easily benefit from this setting. There are still cases where we force caching or force no caching; e.g. reporting selection always forces caching, while second and subsequent presses of item edge movement commands always cache (since you're presumably pressing them rapidly at that point and have sufficient context from the previous press).
— Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/pull/752#issuecomment-1225610820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNKY24L6KDPFR2I4YEPUZLV2YD3FANCNFSM5UZVZWYA. You are receiving this because you are subscribed to this thread.
Very nice. Working very well here in Windows also. Implementing this in Osara itself is a much cleaner solution than having to import the keymap and LUA script.
Thanks.
--Pete
From: Ambro86 @.> Sent: Sunday, May 1, 2022 5:09 AM To: jcsteh/osara @.> Cc: ptorpey @.>; Mention @.> Subject: Re: [jcsteh/osara] Add a "Report full time for time movement commands" configuration option. (PR #752)
Thanks a lot! I've tried it on Windows and all works perfectly!
— Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/pull/752#issuecomment-1114204882 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJJ4GYB4DFMU5AR3EQDVHZQ4HANCNFSM5UZVZWYA . You are receiving this because you were mentioned.Message ID: @.***>
Thanks a lot! I will try this last version. How to activate the full report of time? Or is actived by default? Thanks.
2022-05-01 12:39 GMT+02:00, AppVeyorBot @.***>:
Build succeeded! Build osara pr752-959,1749df37 completed (commit https://github.com/jcsteh/osara/commit/1749df379f by @jcsteh) Downloads:
-- Reply to this email directly or view it on GitHub: https://github.com/jcsteh/osara/pull/752#issuecomment-1114198243 You are receiving this because you were mentioned.
Message ID: @.***>