osara icon indicating copy to clipboard operation
osara copied to clipboard

Add a button in the Parameters dialog to show an envelope for the current parameter.

Open jcsteh opened this issue 3 years ago • 6 comments

I find creating FX envelopes really tedious. I can do it using control+alt+l (show envelope for last touched FX parameter), using the Param button in the FX chain dialog or using the envelopes dialog. Unless I'm missing something, I still find all of these somewhat inefficient/unintuitive. Last touched is probably the fastest, but that still means opening the OSARA FX Parameters dialog, wiggling the parameter, closing the dialog and finally pressing control+alt+l. This pull request adds a "Show envelope" button to the Parameters dialog, no wiggling required.

Currently, this only works for track and take FX. It won't work on track/item parameters, even though it shows up there. I might be able to get it working for some of those parameters, but I'm not sure yet.

Questions:

  1. Would anyone other than me find this useful? Now I think about it, wiggling the parameter and pressing control+alt+l (you don't even have to close the dialog any more) isn't that hard. I don't know why it bothered me so much last time I had to do it. :)
  2. Is it useful to get this working for other track/item parameters that support it?
  3. The button will exist even if the envelope is already shown. Is that a big deal?

jcsteh avatar May 27 '21 13:05 jcsteh

Build failed! Build osara pr533-551,2a919292 failed (commit https://github.com/jcsteh/osara/commit/2a919292fd by @jcsteh)

AppVeyorBot avatar May 27 '21 13:05 AppVeyorBot

Build succeeded! Build osara pr533-552,36201db8 completed (commit https://github.com/jcsteh/osara/commit/36201db8c5 by @jcsteh) Downloads:

Windows
Mac

AppVeyorBot avatar May 27 '21 14:05 AppVeyorBot

It's useful for people who need FX parameter automation.

cn-peter avatar May 27 '21 14:05 cn-peter

Yes, James, it's a great proposition! Greetings!

Lo-lo78 avatar May 27 '21 14:05 Lo-lo78

Now I think about it, wiggling the parameter and pressing control+alt+l (you don't even have to close the dialog any more) isn't that hard.

This is your friendly rabbit hole alarm notification. :) Up to you what you spend your time on man, but I'm not seeing any immediate UX benefit to this yet. Folks who've said it's useful, please explain how/why with use case examples.

ScottChesworth avatar May 27 '21 14:05 ScottChesworth

I don't think this change will benefit as long as it doesn't work for track parameter envelopes.

LeonarddeR avatar Sep 21 '21 16:09 LeonarddeR

This is no longer needed now that we have keyboard access to the Envelopes dialog.

jcsteh avatar Aug 24 '22 11:08 jcsteh