osara
osara copied to clipboard
I179
Build succeeded! Build osara pr1077-1420,828f79ab completed (commit https://github.com/jcsteh/osara/commit/828f79abb1 by @ScottChesworth) Downloads:
Hey @day-garwood, just commited some small tweaks, figured I'd explain in a comment as well seeing as I know you're new-ish to GitHub and I don't know how comfortable you are reading diffs yet.
- I've tweaked the names of the two functions to keep them aligned with others. We use report instead of announce. Your functions are now called reportTempoTimeSig and cmdManageTempoTimeSigMarkers.
- Minor presentation tweak, we do "void functionNameCamelCased() {", opening on the same line.
- We leave a single blank line between each function, even if they're closely related.
- Adjusted the name of the new action to make the double press functionality clear in shortcut help, because I suspect a grand total of about 0.2 percent of users will look this up in the readme before screaching about a bug on RWP lol.
- Also tweaked the action ID just for consistency.
That's all I got for now. Thanks again! Gonna wait for @jcsteh to look this over before merging, only because it's a first contribution.
I know nothing about diffs so that was very helpful. Thanks.
@ScottChesworth, you unfortunately can't submit a pull request against a pull request like this. If you wanted to do that, you'd need to submit a PR to @day-garwood's repository, which @day-garwood would then have to merge. The easier way to do this is to just push commits directly to @day-garwood's branch, which you should have access to do because you're an OSARA collaborator. I'll do this myself now and close this PR, but just dropping this note here for future reference.
Oops, didn't know that. Thanks for tidying up!