axSGrease icon indicating copy to clipboard operation
axSGrease copied to clipboard

Published 20 hours ago • verified publisher icon jcsteh

Add compare

Open derekriemer opened this issue 8 years ago • 4 comments

derekriemer avatar Jan 09 '17 05:01 derekriemer

Um, what? there's some weird changes here.

derekriemer avatar Jan 09 '17 05:01 derekriemer

All good. I forgot to pull before creating the branch, and tried to undo my earlier change.

derekriemer avatar Jan 09 '17 05:01 derekriemer

Bleh. GitHub seems to have squelched my line comment when I was messing with the review summary.

Are you sure this block is the one you actually wanted to change? Did it have the intended effect? I thought you were saying you wanted to add headings for the file headers (which is another block later in the code). This block is for comments... but I'm guessing compare pages don't have comments. Also, please ensure you update the comment inside the block you change.

jcsteh avatar Jan 11 '17 02:01 jcsteh

@DerekRiemer, do you intend to continue work on this? There are outstanding review actions; see https://github.com/nvaccess/axSGrease/pull/8#pullrequestreview-16057502 and https://github.com/nvaccess/axSGrease/pull/8#issuecomment-271759834.

jcsteh avatar Jan 28 '18 17:01 jcsteh