axSGrease icon indicating copy to clipboard operation
axSGrease copied to clipboard

Reordering issues functionality overridden

Open LJWatson opened this issue 8 years ago • 4 comments

Github has recently introduced the ability to reorder issues under milestones using buttons. When the Greasemonkey/Tampermonkey scripts are enabled, these buttons are not recognised. In Chrome and Firefox with NVDA, there doesn't seem to be any indication that the buttons are present at all. In Firefox with Jaws it's the same, but in chrome the buttons are reported as graphics (with "move up" or "move down" also announced).

LJWatson avatar Jun 23 '17 13:06 LJWatson

I can't figure out how to reproduce this, although I swear I saw it a few weeks ago.

derekriemer avatar Nov 20 '17 19:11 derekriemer

I think you'll only see this when viewing open issues for an open milestone. The reason is probably that the graphics end up occurring outside of a role="cell", so they are invalid as far as the table structure is concerned. If I'm right, we'd either need to aria-owns them into another cell or create another cell for them. The latter would be better, but is problematic if some rows have them and some don't.

jcsteh avatar Nov 20 '17 22:11 jcsteh

It looks like the button for reordering has role cell on it.

mcking65 avatar Nov 20 '17 22:11 mcking65

Oh right. Yeah, I guess that makes sense. That's kinda tricky because the button needs to be within a cell, but it isn't itself a cell. We really don't want to mess with the hierarchy, so I guess we'll need some aria-owns black magic here.

jcsteh avatar Nov 20 '17 23:11 jcsteh