James C Scott III

Results 183 comments of James C Scott III

It is likely getting caught in the ANY_VALUE term May need to change the [grammar](https://github.com/GoogleChrome/webstatus.dev/blob/main/antlr/FeatureSearch.g4) to be something like this: ```diff search_criteria: generic_search_term - | ANY_VALUE; // Default to ANY_VALUE...

From the Jun 11, 2024 error report Here are some other invalid queries that should return 4xx instead of 5xx - https://api.webstatus.dev/v1/features?q=available_on%3Achrome%20available_on%3Afirefox%20available_on%3Asafari%20baseline_status%3Awidely%20name%3A%22a%20substring%22%20baseline_status%3Awidely%20-&page_size=25 - Query: `available_on:chrome available_on:firefox available_on:safari baseline_status:widely name:"a substring"...

Definition of done for this bug: - [ ] Modify the [grammar](https://github.com/GoogleChrome/webstatus.dev/blob/main/antlr/FeatureSearch.g4) and run `make gen` to generate the generated files - [ ] Make any necessary changes to the...

From Oct 21 report. Queries that should be returning 4xx instead of 5xx - https://api.webstatus.dev/v1/features?q=group&page_size=25 - Query: `group` - Explanation: Missing colon and value. - ![image](https://github.com/user-attachments/assets/98386462-2d26-4cc2-b43b-6aa956bda109)

From Nov 20 report: Query: `name:"has()" OR name:light-dark`

New report: ![image](https://github.com/user-attachments/assets/00dfb603-7dcc-4afc-82b7-8523c1469368) A few things happening: 1. The colon was not encoded for some of them (and the date is the wrong format. M-D-YYYY) - Example bad query: https://api.webstatus.dev/v1/features?q=baseline_date:12-26-2024..1-2-2025%20AND%20baseline_status:newly...

TODO: List out the components that need the loading state

TODO: Go back through the playwright tests that wait X seconds and instead wait for these loading states to be finished

For this iteration, focus only on: - Overview page - Page loading of the overview table. It should use the existing skeleton view in between pages - Feature detail page...

This makes sense. I held off because we will need to implement some security features first. First, we will want to use something like https://github.com/microcosm-cc/bluemonday to sanitize the field. (I...