lud icon indicating copy to clipboard operation
lud copied to clipboard

Made resconf compatible with Windows

Open LinFor opened this issue 6 years ago • 3 comments

Just added second implementation of rescon module with conditional compilation by target OS.

LinFor avatar Feb 13 '20 14:02 LinFor

Thanks for sending this. Do you mind fixing the missing newlines on some of these files?

jcrowgey avatar Feb 13 '20 15:02 jcrowgey

Hello. Not sure what exactly you meant, but now all the files contain a trailing line feed. I'm newbie in rust and don't know style conventions. I'm using your project as a good starting point, fell free to correct me.

LinFor avatar Feb 14 '20 08:02 LinFor

Hello. Not sure what exactly you meant, but now all the files contain a trailing line feed. I'm newbie in rust and don't know style conventions. I'm using your project as a good starting point, fell free to correct me.

For reference on newlines, see 1. If you don't do this, standard tools like diff generate awkward messages:

$ diff <(echo "hi") <(echo -n "hi")
1c1
< hi
---
> hi
\ No newline at end of file

It's that awkward "\ No newline at end of mile" message which github was translating into the red arrow on your diff. Anyway, thanks for correcting it. :)

I know next to nothing about Windows and how it does networking. Does lud actually work on windows after this change? I'm curious.

Finally, let's leave in Cargo.lock (for now), as per 2. After that, this looks ready to merge. And thanks again.

jcrowgey avatar Feb 14 '20 16:02 jcrowgey