fixed boolean reading

Open apesti opened this issue 7 years ago • 2 comments

Couldn't read booleans because they were set to 0 in the thrift file which would then evaluate to False when checking their truth value. Changed it so it specifically checks whether the type is None.

Apr 04 '18 07:04 apesti

thanks for the fix - do you happen to have a simple test case that we can add?

I'll look into why the CI build failed; it seems unrelated.

Apr 04 '18 17:04 jcrobak

Sorry I don't have one and I couldn't figure out how to make one for this but any small parquet file with booleans should work as a test case.

Apr 04 '18 23:04 apesti