skein
skein copied to clipboard
Add a method to bypass YARN Proxy and provide a direct link in Services Page
Service pages in a Skein application is very useful. However being forced to go through the YARN Application Proxy can be problematic in some cases.
- limitations on HTTP Verbs
- SPA like Tensorboard, when launched through the YARN Web Proxy fail their xhr requests as they use the host:port in their URL rather than the full proxy path
Although this can be fixed on a per app/SPA, It would be very interesting to have a flavor of the ui.add_page method that allow to register the final link in the Service Page.
wdyt?
Seems reasonable to me. I'd handle this by adding a proxy=False
kwarg to add_page
, defaulting to True
. I'd also probably rename the ProxiedPage
class to Page
, and add a proxied
attribute to that class.
Would you be interested in working on this?
Yes I can work on it.
When proxy=False, what about the route parameter? I would ignore its value in this case, only the link_name and the url is required.