James Wyatt Cready-Pyle

Results 79 comments of James Wyatt Cready-Pyle

We're getting a little outside the scope of protobuf-ts here. Basically you need the `refreshAccessToken` function to be memoized (i.e. return the _same_ promise to all callers based on if...

What you have basically does nothing since you aren't actually doing anything in the error handling (you aren't retrying the request with a new access token, just re-throwing the error)....

There is only [partial support for `proto2`](https://github.com/timostamm/protobuf-ts/blob/main/MANUAL.md#proto2-support). The `required` label is not supported. At least for `toJson` there [is an option to `emitDefaultValues`](https://github.com/timostamm/protobuf-ts/blob/main/MANUAL.md#json-format), but there is no such option for...

The timeout/deadline is simply sent as a request header to the server. There is no `setTimeout` being used client-side. The issue would be with the server not respecting the `grpc-timeout`...

Even if there were an option to allow you to pass in your own `fetch` function I don't think it would help you with your svelte/SSR goal. In your link...

Can you provide more details for how to reproduce this issue (protoc args, tsconfig, etc.)? As far as I know name clashes with global/reserved identifiers is already taken care of...

Also, if you could show what the "View compiled" (at the bottom of your screenshot) shows that would also help. FWIW it _seems_ like the reported error message shown isn't...

Yeah, it looks like a bug with webpack where it seems to incorrectly assume that the in-scope `Object` identifier will always be referencing the global `Object` class when that isn't...

I believe I have a solution that can work for the existing v2 representation. I know this `PartialMessage` is depended upon heavily so it's possible I'm not properly covering some...

What happens when the message is recursive? ```proto message Foo { Bar bar = 1; } message Bar { Foo foo = 1; } ``` Your proposal would cause a...