James Wyatt Cready-Pyle

Results 79 comments of James Wyatt Cready-Pyle

> Wouldn't you still get the same type safety with this? > ```ts > itemType: { > post: Post; > } | { > profile: Profile; > } | {...

It probably doesn't outweigh the benefits, but I'd like to point out one benefit of the old logger: I could force unit tests to fail which had query issues by...

Right, my point is that many libraries (not just this one) use console.error() to warn about deprecations (e.g. things that explicitly **don't** need to fail my tests).

Here's my attempt at the proposed interceptor: ```ts import { RpcError, RpcInterceptor, RpcMetadata } from '@protobuf-ts/runtime-rpc'; const noop = () => {}; function combineRpcMetadata(a: RpcMetadata, b: RpcMetadata): RpcMetadata { const...

@dawsonc623 that discussion seems a bit unrelated to this issue. This issue is asking for the RpcMetadata received in the response headers to be included in the RpcError (which currently...

@dawsonc623 are you sure the service is sending `grpc-status-details-bin` in its response (headers or trailers)? You could try to use [the interceptor I posted above](https://github.com/timostamm/protobuf-ts/issues/628#issuecomment-1932031413) which should combine the headers...

The `PostalAddress` name clash error seems like an unrelated bug that should have its own GH issue and should be fixed. The import should be aliased in the compiled code.

FWIW my suggested solution using `WeakMap` does have some unintended consequences with regard to unknown fields. Currently the behavior of unknown fields is to set an **ENUMERABLE** `Symbol` (unlike the...

I also want to point out that stamping the message with the `Symbol` is rather expensive. When benchmarking binary reads (on nodejs v20) I'm seeing an almost 2.5x improvement if...

So far I've only found one way to maintain the current symbol stamp (and all its enumerability behaviors) while avoiding the slow down: define an **EMPTY** class for creating message...