idna-uts46 icon indicating copy to clipboard operation
idna-uts46 copied to clipboard

Replace use of ES6 for..of with `punycode.ucs2.decode`

Open Arachnid opened this issue 7 years ago • 3 comments

(Now confirmed to pass all unit tests!)

This PR replaces the use of for..of with punycode.ucs2.decode an punycode.ucs2.encode, removing the dependency on ES6, and therefore making it more browser-friendly.

Arachnid avatar May 31 '17 12:05 Arachnid

+1 Please merge as it has no side effects.

jdkanani avatar Aug 23 '17 10:08 jdkanani

@jdkanani until this is done, you may give idna-uts46-hx a try. my fork that already covers this.

KaiSchwarz-cnic avatar Aug 23 '17 11:08 KaiSchwarz-cnic

Any chance of this PR getting some love?

Arachnid avatar Jan 17 '19 02:01 Arachnid