SPIDER icon indicating copy to clipboard operation
SPIDER copied to clipboard

Bump log4j-api from 2.16.0 to 2.17.1

Open dependabot[bot] opened this issue 3 years ago • 0 comments

Bumps log4j-api from 2.16.0 to 2.17.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Jan 04 '22 16:01 dependabot[bot]

While I understand the sentiment, I don't think our enterprise customers would welcome it.

That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.

I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."

ppisar avatar Apr 16 '24 08:04 ppisar

While I understand the sentiment, I don't think our enterprise customers would welcome it.

That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.

I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."

In addition to all of this (which is very much YES), if you're going to decorate terminal messages, might as well just take a page from homebrew and use real emoji. #KidsToday won't even know what :) means! :wink:

ferdnyc avatar Jul 29 '24 13:07 ferdnyc

I was searching for some repositories in order to start my open source contribution journey today, and then I saw this cute PR : )

jackiesogi avatar Oct 16 '24 18:10 jackiesogi

I moved over to Arch, but I am booting up a fedora server, so I have a reason to actually build this. If anyone has any suggestions, please send them this way :)

QuantumLoopHole avatar Oct 17 '24 01:10 QuantumLoopHole