SPIDER
SPIDER copied to clipboard
Bump log4j-api from 2.16.0 to 2.17.1
Bumps log4j-api from 2.16.0 to 2.17.1.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
While I understand the sentiment, I don't think our enterprise customers would welcome it.
That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.
I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."
While I understand the sentiment, I don't think our enterprise customers would welcome it.
That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.
I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."
In addition to all of this (which is very much YES), if you're going to decorate terminal messages, might as well just take a page from homebrew and use real emoji. #KidsToday won't even know what :) means! :wink:
I was searching for some repositories in order to start my open source contribution journey today, and then I saw this cute PR : )
I moved over to Arch, but I am booting up a fedora server, so I have a reason to actually build this. If anyone has any suggestions, please send them this way :)