crater icon indicating copy to clipboard operation
crater copied to clipboard

styles/global/global.css not working

Open Falieson opened this issue 8 years ago • 3 comments

Code: https://github.com/jcoreio/crater/compare/webpack2...Falieson:wp2_globalCSSloaders-broken

$ yarn test:dev

[phantomjs #0-0] 1 failing
[phantomjs #0-0] 1) dev mode serves up global css:
[phantomjs #0-0] expected '8px' to equal '0px'

Falieson avatar May 05 '17 12:05 Falieson

I saw that global CSS is in the webpack config - is global.css supposed to be accessed the same way other .css files? I suppose I made an assumption here that it was built as a final asset because of its title.

Falieson avatar May 05 '17 21:05 Falieson

Oh, huh... I'll have to check what went wrong later. The global css is supposed to be just good old fashioned css to include on every route, whereas all other css files are configured to use css modules, and be imported for specific routes and components.

jedwards1211 avatar May 06 '17 13:05 jedwards1211

That's exactly how I thought it was supposed to work! :-)

Falieson avatar May 06 '17 15:05 Falieson