crater icon indicating copy to clipboard operation
crater copied to clipboard

Manually calling React.PropTypes validation function on Html (Warning)

Open Falieson opened this issue 8 years ago • 4 comments

== STR

  • When running npm run start
  • and a successful webpack build
  • in a browser go to localhost:4000

webpack server terminal receives output

Warning: You are manually calling a React.PropTypes validation function for the `__meteor_runtime_config__` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
Warning: You are manually calling a React.PropTypes validation function for the `store` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
Warning: You are manually calling a React.PropTypes validation function for the `title` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
Warning: You are manually calling a React.PropTypes validation function for the `assets` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

@jedwards1211 I'll probably submit a PR for this in the next day or two

Falieson avatar Apr 24 '17 16:04 Falieson

@Falieson yes, this is an unfortunate side effect of react-dom-stream. I guess they'll fix that when the churn around PropTypes dies down.

jedwards1211 avatar Apr 25 '17 14:04 jedwards1211

what does STR stand for by the way?

jedwards1211 avatar Apr 25 '17 14:04 jedwards1211

STR = Steps To Reproduce

Thanks for letting me know its from a 3rdparty package and not something I can fix in the repo

Falieson avatar Apr 25 '17 17:04 Falieson

I almost think I should get rid of react-dom-stream and just stick with react-dom for now. It's fairly experimental...in fact it uses a fork of React internally. Another downside of react-dom-stream is that if a React component throws an error in the middle of SSR, it's impossible to send a 500 status code because it already had to send 200 to start streaming the HTML.

jedwards1211 avatar Apr 28 '17 16:04 jedwards1211