crater icon indicating copy to clipboard operation
crater copied to clipboard

Webpack2 for pr 142 144 145

Open Falieson opened this issue 8 years ago • 7 comments

webpack2 soft changes for PRs #142 #144 #145

almost the same thing as what I submitted to master in those PRs but included link to setup "autochange to node6"

upgrade packages 20170422

  • went through and upgraded packages that were behind master
  • npm run test fails on branch master before I made any changes to the package.json
  • npm run test:dev passes

Falieson avatar Apr 23 '17 04:04 Falieson

Coverage Status

Coverage remained the same at 89.63% when pulling f051aaa834e75ec1d1d53ad63a9267e039de4518 on Falieson:webpack2_for-pr_142-144-145 into 2b97ce07785f103032f9879e504a4bddcf0e39ae on jcoreio:webpack2.

coveralls avatar Apr 23 '17 04:04 coveralls

Coverage Status

Coverage remained the same at 89.63% when pulling f051aaa834e75ec1d1d53ad63a9267e039de4518 on Falieson:webpack2_for-pr_142-144-145 into 2b97ce07785f103032f9879e504a4bddcf0e39ae on jcoreio:webpack2.

coveralls avatar Apr 23 '17 04:04 coveralls

Coverage Status

Coverage remained the same at 89.63% when pulling f051aaa834e75ec1d1d53ad63a9267e039de4518 on Falieson:webpack2_for-pr_142-144-145 into 2b97ce07785f103032f9879e504a4bddcf0e39ae on jcoreio:webpack2.

coveralls avatar Apr 23 '17 04:04 coveralls

@Falieson sweet, thanks! Greenkeeper is getting kind of annoying, I wish I had a script to just periodically make PRs with all deps upgraded at once.

jedwards1211 avatar Apr 25 '17 14:04 jedwards1211

Hmmm I'm on the fence about .nvmrc though. Some users may want to run it with different versions of node, and that would practically force them to run it with 6.10. Let's keep .nvmrc out of this repo, of course you can still have it and gitignore it in your own working copy

jedwards1211 avatar Apr 25 '17 14:04 jedwards1211

sounds good - I'll get you those updates and do another update for the readme with a recommendation for the nvm and autoswitching

Falieson avatar Apr 25 '17 16:04 Falieson

Going to wait until #142 and #144 are resolved to update this

Falieson avatar May 02 '17 22:05 Falieson