Joshua T Corbin
Joshua T Corbin
Also, look no further than [os.Create](https://golang.org/src/os/file.go?s=9329:9368#L305) for "what should the defaults be?" The only reason that zap doesn't uses `os.Create` is due to wanting append semantics rather than truncation, but...
A `zap.NoneLevel = -1000` (or so) seems reasonable to me; in addition to sampler (as mentioned by prashant) I suppose we should add guards to all care implementations that zap...
Of the two options you describe, adding a new `zap.BinaryHex` field is right out: separation of field definition from encoding is a primary design goal of zap. For the 2nd...
> Regarding the second option, that was my only concern that a new field in zapcore.EncoderConfig will be useless for some encoders but if you think that's not a big...
it's also amusing to observe that the endpoint delay that I added will probably allow to test at higher scale of other parameters, even in travis, since the cpu is...
@jwolski , since I've taken over this can of worms, I'd like to understand the difference between the `"membershipChanged"` and `"ringChanged"` events: - it's unclear to me from the above:...
@rf, I started trying to write a membershipChanged test here: #116
may be a small perf win for partial affinity
Aye, stats on changes and updates would be great, will add. Currently the only affect of `updateServiceNodes` is under the partial affinity feature, so noop until then.
So what are the chances of the http-server binary adding support for a custom handler? Looking at `lib/http-server.js`, it does take a `before` option that would allow wiring up a...