jcmcote

Results 13 comments of jcmcote

I have updated the JIRA ticket with the latest patch. Using this approach you can expect 25% less time to execute the like UDF. I've added details in the JIRA...

Just wondering when this patch will be included in the drill code base. I updated the JIRA issue with a new patch file. Thank you

I guess it slipped through the cracks. No worries. I did not convert the "isnumeric" UDF to use a CharSequence wrapper since I don't really understand how the templating mechanism...

just following up, did the tests all pass?

Hey Sean, You did not apply the correct patch. I made the code review changes you asked and updated the patch in the jira ticket. But somehow the code that...

Hey @hsuanyi ok, fixed the regex_replace and added a test case. There's a new patch on the ticket. Please apply it and commit. thanks

@hsuanyi just following up to see if the patch was applied.

I have attached the patch to the Jira ticket. I'm not sure of the usual process.. but from what I was reading we can create patches and attache them to...

I know where the issue lies. It's related to the mapping between the unicode encoded bytes from the drillbuffer and the conversion to chars. I'll will address the mapping issue...

> @jcmcote, in [HADOOP-13578](https://github.com/apache/hadoop/commit/a0a276162147e843a5a4e028abdca5b66f5118da#diff-8983b1157165c3e54c37877bc01da2ec) was added ZStandard Compression to the hadoop library. I think it would be better to collaborate with existing well-tested implementation instead of introducing the custom one....