jquery-timer icon indicating copy to clipboard operation
jquery-timer copied to clipboard

Code mismatch between download/demo

Open EleventyOne opened this issue 11 years ago • 1 comments

The code available here: http://jchavannes.com/include/scripts/3p/jquery.timer.js

Is different than the code available here: http://jchavannes.com/download/jquery-timer-demo.zip

I had been using them interchangeably until I found a bug that only showed up when I used the hosted version of the code. The bug doesn't show up on the downloaded version.

In brief, the bug was that I couldn't get a timer to restart itself by calling .play() after calling .stop() - in a very convoluted scenario. Using the downloaded version solved the problem.

EleventyOne avatar Nov 17 '13 04:11 EleventyOne

Right, so after trying to chase down this bug for a while, it seems that it goes away when I rename the this.active to this.ANYTHINGELSE (it was magically getting set to 0 after .play() was called and before .go() was executed).

Of course, I see now that this is the only change made to the source code that's available for download. So, yeah. Good times! :)

Nevertheless, it might be worthwhile updating the hosted source code, in case someone else should run into the same kinda trouble.

EleventyOne avatar Nov 17 '13 05:11 EleventyOne