Results 38 comments of Jerry Cheung

> shall I separate out the use_connection refactor into a separate pull request and get that in :+1: to a separate PR @mtodd I'm skeptical of duplicating all or any...

@Ajedi32 that's a good suggestion. Would you be interested in creating a pull-request for this? It should be pretty straightforward, and the relevant hash components would be here https://github.com/ruby-ldap/ruby-net-ldap/blob/master/lib/net/ldap/filter.rb#L28-L35

That gem name is a mouthful, but I think it's clear what it's supposed to me. We can also link to it from the README so it's easier for others...

Did it get yanked? If the implementation isn't too long, you could find the code and just inline it into your gem.

@zjuanma I haven't had time to work on this, but if you start a pull request, I'd be happy to review it.

@ojab @mattcg I think the idea is good, but I would prefer the changes to be more explicit and to have less metaprogramming. Comments inline.

I'd be happy to help review a pull if you've come up with a solution you like.

That sounds like a good custom subclass. Would you be interested in trying to implement it and submit a pull request?