date-input-polyfill icon indicating copy to clipboard operation
date-input-polyfill copied to clipboard

Breaking layout when data-open is false

Open lucasghizoni opened this issue 8 years ago • 1 comments

Hello, I would like to know why you guys used the following code on date-input-polyfill.scss:

&[data-open="false"] { visibility: hidden; z-index: -100 !important; top: 0; }

Instead of just using this:

&[data-open="false"] { display: none; }

I am questioning that, because the date-input-polyfill Element is occupying some space when attribute data-open is false, breaking my layout. If you agree with this little change, i make a pull request.

lucasghizoni avatar Feb 17 '17 10:02 lucasghizoni

try it in a fork and see how it goes if everyting is working correctly make a pr

jcgertig avatar May 30 '17 14:05 jcgertig