gradle-notifier
gradle-notifier copied to clipboard
time displayed in messages has decimal places for hours and minutes
I started using this plugin to get desktop notifications (linux/notify-send) when my longer running tasks completed. This has been a huge help, so much appreciated. However, I noticed that the displayed times included quite a few decimal places on the hours and minutes fields, which is technically incorrect (1.5 minutes and 30 seconds = 2 minutes) but also just makes for an awkward-looking message.
I actually got curious enough to clone the repo and fix it myself, so I have a fix in a local branch that fixes this, and I got a bit carried away and made it use correct singular/plural forms of hour(s)/minute(s)/second(s) because I was having some fun. I also wrote a full set of tests to cover.
I'd be more than happy to upload my changes and create a PR if given permission. I've been running this locally for a few days... I added the maven plugin (not included in branch) so I could use publishToMavenLocal
and run my customized version for all projects.
Glad to hear that this plugin is useful to you 👍.
I'm sorry to not have seen this before 😇.
I would like to merge your PR if you opened one. You don't need any permission, you can just create a fork from this repository and create your pull request :
- https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks
- https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork