Jean-Christophe Fillion-Robin

Results 811 comments of Jean-Christophe Fillion-Robin

@lassoan Once you approve https://github.com/Slicer/Slicer/pull/8831, it can be merged. Then you could follow-up with PR changing the default and that would close this issue.

> All these would worth some more investigation before we change the default method to surface nets. Therefore it might make sense to change the default in Slicer 5.11. Agreed....

Before adding validation, I suggest to add the missing annotation types by fixing the errors reported after enabling the `ANN` checks associated with ruff linting introduced in: * https://github.com/BrownBiomechanics/Autoscoper/pull/190

Relevant documentation: * Python Type Hints - How to Type a Descriptor: https://adamj.eu/tech/2021/10/18/python-type-hints-how-to-type-a-descriptor/

We should also look into `typeguard`. See https://typeguard.readthedocs.io/en/latest/extending.html It seems like we could specify custom types as annotation and have these used at runtime when the function is called. Also...

_This should be further improved following guidance originally posted by @glankk in https://github.com/danmar/simplecpp/issues/448#issuecomment-3084543319_ > I suggest we emulate gcc's darwin-specific `-F` option, and possibly `-iframework` as well. See https://gcc.gnu.org/onlinedocs/gcc/Darwin-Options.html. The...

> Looks like this is currently executed for all code even if there is no apple framework is available which seems excessive. Indeed, this was a deliberate choice anticipating the...

@glankk Thanks for the suggestion :pray: All the review comments have been addressed. Once the GitHub workflow have been enabled and the test pass, I believe this will be ready...

Waiting this is integrated, we will stage those changes into a fork and move forward with vendoring those into `PythonQt`. Related: * https://github.com/MeVisLab/pythonqt/pull/271

Thanks again @hjmjohnson for working on the initial patch and establishing the momentum :pray: Hopefully our contributions will be integrated shortly :crossed_fingers: