José Carlos Chávez
José Carlos Chávez
This PR is still a POC of a `responseReader` which would allow users to record more information in the span based on the response. The use case that triggered this...
Currently, responses with status code
https://github.com/openzipkin/zipkin-js/pull/369/files#r297988407
Since [connect package](https://github.com/openzipkin/zipkin-js/tree/master/packages/zipkin-instrumentation-connect#zipkin-instrumentation-connect) covers the instrumentation both for express and restify, should we start suggesting over those packages to use connect instead? Anyone see any drawback on this? Ping @openzipkin/zipkin-js-champions...
Most zipkin clients include a set of tags for the tag keys. Should we have such a thing in JS? Ping @adriancole @yonran @eirslett
At the moment there is no way to customize (e.g. adds tags or logs) the `span` create by server frameworks. Use cases could be: 1. Add request ID from headers...
ATM we are not validating the traceID neither the spanID making it possible to receive `a` or `abc`. I believe it is worth to validate it like in other `zipkin`...
Right now `getmesh check-upgrade` displays: ``` [Summary of your Istio mesh] active istioctl version: 1.11.3-tetrate-v0 control plane version: 1.11.3-tetrate-v0 [GetMesh Check] - There is the available patch for the minor...
Currently this project includes way too many dependencies as it is a single module. Making all of them a different module would avoid users to pull dependencies that aren't important...
As of now, when wrapping an error we keep the cause of the error meaning that if we want to handle the error in a upper layer we need to...