Luis Caro Campos
Luis Caro Campos
This build was successful but the status check was not reported back to GitHub - will be updated shortly
Hi @dbolduc - currently reviewing this, aiming to have a review today, thanks!
Are the changes in https://github.com/conan-io/conan-center-index/pull/23233/commits/a0480a22774477e3c68d40e35f298a6f0e6b09a1 motivated by a bug? I would avoid changes like these if that's not the case.
> Mostly to follow the CMake/Conan conventions: https://github.com/conan-io/conan-center-index/pull/25381#discussion_r1773373957 I see - that was in response to the addition of `CMAKE_POLICY_DEFAULT_CMP0077`- where that's an indicator `cache_variables` should be used. Apologies if...
If I remember correctly, if `CMAKE_FIND_ROOT_PATH_MODE_{LIBRARY,INCLUDE,PACKAGE}` is set to `ONLY`, and there is a `CMAKE_SYSROOT` defined, none of the calls to `find_package`/`find_library`/`find_program` will work to locate anything provided by Conan...
This is great!! I wonder if we could address the usage of the `stdcpp_library()` helper. Some recipes build libraries that have a pure "C" interface but encapsulate compiled C++ code....
pleaase be aware that version bumping like this introduces a conflict in opentelemetry-cpp. I would advise against bumping versions unnecessarily unless there is a clear reason - for example, a...
Facing the same problem - building the shared library on macOS with all dependencies provided externally. Using protobuf 27 I can see homebrew's test bot is also experiencing this: https://github.com/Homebrew/homebrew-core/pull/170194
> > I guess this is all targets with cmake argsuments: -DBUILD_SHARED_LIBS=ON -DgRPC_ABSL_PROVIDER=package -DgRPC_BENCHMARK_PROVIDER=package -DgRPC_CARES_PROVIDER=package -DgRPC_PROTOBUF_PROVIDER=package -DgRPC_RE2_PROVIDER=package -DgRPC_SSL_PROVIDER=package -DgRPC_ZLIB_PROVIDER=package. > > Does this work without providing the additional arguments? `-DBUILD_SHARED_LIBS=ON`...
I suspect the missing symbols are in `descriptor.upb_minitable.c` - which is built into the `grpc` and `grpc_unsecure` cmake targets. The symbols are not built nor referenced in the `upb_textformat_lib` or...