Jamie Cansdale

Results 93 comments of Jamie Cansdale

Hi @terrajobst 👋 There appears to be strange things going on with PAT scopes and what the GraphQL query returns. I've created a repository here with your repro: https://github.com/jcansdale-test/terrajobst-issue-234 When...

For reference, here is the query that it having problems: ``` query { repository(name: "runtime", owner: "dotnet") { id issues(filterBy: { assignee: "*",createdBy: null,labels: null,mentioned: null,milestone: "*",since: "2020-06-26T09:30:00+01:00",states: null,viewerSubscribed: null...

@terrajobst, > However, not all authenticated users will have write access to the repos the query is executed against. I still need those results to be reliable/complete though. I think...

@terrajobst, Any idea which element is coming up null? You could try adding some guards like this: ```cs Items = connection.Edges.Select(e => new { Name = e.Node != null ?...

@HiKoLaaa, > In my repository 200+ issues. I suggested that if I ran this query, I was getting all issues with their comments. But result was only 200. When I...

We do have `AllPages` unit and integrations tests. We even have some with inner paging, but we only check that they complete. See: https://github.com/octokit/octokit.graphql.net/blob/9e944187f18dd765f948d5b381900a8162e3267d/Octokit.GraphQL.IntegrationTests/Queries/PullRequestTests.cs#L81

I have a failing integration test for this here https://github.com/octokit/octokit.graphql.net/pull/237 This existing assert so early caught the issue: https://github.com/octokit/octokit.graphql.net/pull/237/files#diff-33750d5aaabf5716b9b31d7ec4dc1200R196 It only passed because it was checking more than 100 issues...

The issue appears to be that subqueries only seem to have a single subquery. For example. here is the main query: ![image](https://user-images.githubusercontent.com/11719160/86531300-ea743b80-beb7-11ea-839d-34b42bf0be03.png) This has two subqueries, one for issues and...

@terrajobst, > Yeah, paging is a big issue for me too. It's a bit unclear to me how one would do manual paging inner sources. It seems one would have...

I don't know if a schema update might fix this? There's a PR with one here https://github.com/octokit/octokit.graphql.net/pull/211. You could compile and pull in the DLLs or nupkg from that.