Jean-Christophe Amiel

Results 360 comments of Jean-Christophe Amiel

Ha, didn't see that this can be problematic with ! Honestly, when reviewing the change log for 5.0.0, I was surprised that we haven't implemented it yet and hesitated to...

Yes, you can find it also in the grammar but we've hand coded the parser from the grammar so the grammar may not be "complete" (see ). The parser code...

Hi @bp7968h I think the better model should be `MaxTime(DurationOption)`, this way we can support without a lot of changes something like `max-time: 500s` or `max-time: {{variable}}`. I've not tested...

Hi @ashishajr yes exactly! I'm assigning it to you

Hi @ashishajr Yes you're totally right the Hurl log is erroneous `curl --header 'Expect: 100-continue' --header 'Content-Type:' --data 'data' --connect-timeout 2 --timeout 10 'http://localhost:8000/expect'` It should be `curl --header 'Expect:...

We're going to change the log for sure. Regarding the name `timeout` I think the intention was to distinguish between the curl option name `max-time` and the functional name which...

Hi @ashishajr yes good catch this should be done now

Another possibiliy: ``` error: Assert body value --> tests_failed/assert_base64.hurl:12:8 | | GET http://localhost:8000/error-assert-base64 | ... 12 | base64,bGluZTEKbGluZTIKbGluZTMK; | ^^^^^^^^^^^^^^^^^^^^^^^^ | actual: | expected: | ``` To be like explicit...

Hi @Geun-Oh , CI issues are not opened to contribution unfortunately. You can however look at issue labeled with "good first issue" if you want to contribute!

Something that I miss I that I'm building on Windows by configuring the `LIBXML2` env. In that case, the returned `binding.rs` is the `scr/default_binding.rs`: - is there a reason why...