Jamie Cameron

I think we should support it - some operating systems like MacOS have default directories with spaces in them.

Best practice in Webmin is to always use `quotemeta` on paths, as failing to do so can cause security issues if the path is in any way controlled by the...

I guess what I meant as *any* user, including `root`. In fact, it's best to quote all paths, because we can never assume that they don't contain unusual characters.

Thanks, I've checked in fixes for these..

I had a look at the code for extracting script files, and I can't see any case where quoting was missed?

Check out the patch I just checked in, and let me know if it helps ..

Thanks for those patches!

Thanks for that fix!

Are you able to fix this be adjusting some of the settings on the module configuration page (the gear icon) to use different commands to start and stop the DC?

Not a bad idea, although it would really need to be a complete rsync backup module rather than just a module that runs rsync ad-hoc.