3P icon indicating copy to clipboard operation
3P copied to clipboard

Enhancement for NormedVariables

Open odin-vii opened this issue 7 years ago • 6 comments

Description of the Issue

Update list of NormedVariables prefixes.

Expected Behavior

I used to update the list in the user defined language. Our company uses dashes (-) instead of underscores (_). Either updating the list permanently or allowing modification some how in the plugin would be nice.

odin-vii avatar Oct 27 '17 14:10 odin-vii

Hello,

Okay sure, i can add an option, at least momentarily. I think ill add dynamic color highlighting on variables later so thi soption should become irrelevant. However, you can not trust the colors to know if you named correctly your variable since it colors w/e its type is (integer call ll_ would be colored but the prefix is wrong). It's better to create a prolint rule to check this. And to be honest, I think this kind of naming convention is obsolete when you use an IDE than can analyse the type of a variable -> but yeah, company/client policies -_-"

++

jcaillon avatar Oct 29 '17 18:10 jcaillon

Great. Thanks.

odin-vii avatar Oct 30 '17 12:10 odin-vii

image

jcaillon avatar Feb 14 '18 18:02 jcaillon

Thanks for the update. I pulled down the latest version and found a 'bug' related to this. The parser is still expecting an _ in the variable. I'm not 100% sure this is the issue, but I think the issue is on Line 111 of /3PA/MainFeatures/SyntaxHighlighting/SyntaxHighlightVisitor.cs:

var pos = tok.Value.IndexOf("_", StringComparison.CurrentCultureIgnoreCase);

odin-vii avatar Feb 19 '18 15:02 odin-vii

Ahm this is awkward... Yes you are totally right, I will correct this.

jcaillon avatar Feb 19 '18 15:02 jcaillon

No worries... thanks for all the time you put into this great plugin. Me and my team thought we would never find a descent tool to use with our progress code base.

odin-vii avatar Feb 19 '18 15:02 odin-vii