jcabi-github icon indicating copy to clipboard operation
jcabi-github copied to clipboard

Assets upload issue with Github enterprise.

Open fred8 opened this issue 5 years ago • 6 comments

RtReleaseAssets upload use a static uri uri: "https://uploads.github.com" this.request.uri().set(URI.create("https://uploads.github.com"))

It should leverage the upload_url in the repository github response.

fred8 avatar Jun 24 '20 23:06 fred8

@amihaiemil/z please, pay attention to this issue

0crat avatar Jun 24 '20 23:06 0crat

Thanks @0crat! I m kind of stuck in my project. I can workaround abd do an extra sh script but not really convenient.

fred8 avatar Jun 24 '20 23:06 fred8

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

0crat avatar Jun 25 '20 00:06 0crat

@fred8 There doens't seem to be any upload_url in the repo JSON returned by the API: https://api.github.com/repos/jcabi/jcabi-github

Or maybe I don't understand what you mean?

amihaiemil avatar Jun 25 '20 05:06 amihaiemil

@amihaiemil Sorry I meant the "release" API response

fred8 avatar Jun 25 '20 17:06 fred8

@fred8 Can you please make a PR? There isn't anyone actively working on this project at the moment and I don't really have time for it either.

If you wanna make a PR, please start small, don't write a lot of code: Qulice (our static code analyzer) will probably kick you from all directions...

amihaiemil avatar Jun 26 '20 08:06 amihaiemil