juice-interface icon indicating copy to clipboard operation
juice-interface copied to clipboard

move top level nav items into TopLeft items component

Open benschac opened this issue 3 years ago • 2 comments

What does this PR do and why?

This PR moves transactions, account, lang from NavBar to mobile collapse and topleftItems. The Navigation will further be refactored to use the new items= API from menu. This is the first step of adding these NavItems and will separate concerns a bit from mobile and desktop headers.

Screenshots or screen recordings

Mobile

CleanShot 2022-10-17 at 20 58 29@2x

Desktop

CleanShot 2022-10-17 at 20 58 18@2x

Acceptance checklist

benschac avatar Oct 14 '22 19:10 benschac

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
juice-interface-goerli ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 1:19PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
juice-interface ⬜️ Ignored (Inspect) Oct 24, 2022 at 1:19PM (UTC)
juice-interface-rinkeby ⬜️ Ignored (Inspect) Oct 24, 2022 at 1:19PM (UTC)
juice-interface-theme-demo ⬜️ Ignored (Inspect) Oct 24, 2022 at 1:19PM (UTC)

vercel[bot] avatar Oct 14 '22 19:10 vercel[bot]

Current dependencies on/for this PR:

  • main
    • PR #2233 Graphite 👈
      • PR #2267 Graphite
        • PR #2235 Graphite
          • PR #2236 Graphite
            • PR #2237 Graphite
              • PR #2238 Graphite
                • PR #2239 Graphite
                  • PR #2240 Graphite
                    • PR #2241 Graphite
                      • PR #2242 Graphite
                      • PR #2321 Graphite
        • PR #2234 Graphite

This comment was auto-generated by Graphite.

benschac avatar Oct 14 '22 19:10 benschac

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: QYaAht6eMvR7hTnqghel

benschac avatar Oct 24 '22 13:10 benschac