juice-interface icon indicating copy to clipboard operation
juice-interface copied to clipboard

Spinner loading issues in history FC for v1

Open nakedfool opened this issue 2 years ago • 1 comments

Summary

This issue is the same as this one https://github.com/jbx-protocol/juice-interface/issues/1839

However, when I was working on v2 projects I've forgotten to apply the same behavior for v1 projects.

Steps to reproduce

  1. Go to https://www.juicebox.money/p/juicebox
  2. Click on History under funding cycle section
  3. When spinner is loading, text that is behind No past funding cycles shouldn't be visible until data comes or does not come back

What is the current bug behavior?

What is the expected correct behavior?

Relevant logs and/or screenshots

Environment

  • Device/OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Hardware wallet: [e.g. Ledger w/ Metamask]

nakedfool avatar Sep 09 '22 07:09 nakedfool

Hmm after looking into this, i actually like how loading logic is done in v1 for history FC, instead of waiting for all cycles to load it is loading cycle by cycle.

therefore for example if the project has many history FC ( for example https://www.juicebox.money/p/juicebox ) it is progressively going to load one by one.. hmm not sure if we should apply the same logic for v2 projects?

cc @tomquirk ( minor issue ser but when you have time look at this )

v1 vs v2

https://user-images.githubusercontent.com/18723426/189902777-265ade89-e58b-49b2-a95e-38b945234d25.mov

nakedfool avatar Sep 13 '22 12:09 nakedfool