juice-interface icon indicating copy to clipboard operation
juice-interface copied to clipboard

Make FormattedAddress component return an EtherscanLink

Open tomquirk opened this issue 1 year ago • 1 comments

What does this PR do and why?

FormattedAddress links throughout the app are currently unintuitive. I expect to be able to click any address and open it in Etherscan. Instead, I have to hover, then click the link in the tooltip.

This PR reworks FormattedAddress to return an EtherscanLink.

Other minor things:

  • remove transition from a elements.
  • remove padding from ClipboardButton
  • clean up formatAddress util a bit.

Screenshots or screen recordings

before after
Screen Shot 2022-08-25 at 2 31 27 PM Screen Shot 2022-08-25 at 2 30 42 PM

Acceptance checklist

tomquirk avatar Aug 25 '22 05:08 tomquirk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
juice-interface-rinkeby ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 4:01AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
juice-interface ⬜️ Ignored (Inspect) Aug 28, 2022 at 4:01AM (UTC)

vercel[bot] avatar Aug 25 '22 05:08 vercel[bot]

friendly bump @wraeth-eth

tomquirk avatar Aug 26 '22 23:08 tomquirk

minor and out of scope for this one - but we could consider making the tooltip address entirely copyable by click, rather than just the copy button

wraeth-eth avatar Aug 28 '22 03:08 wraeth-eth