Jared Watts

Results 377 comments of Jared Watts

i like the spirit of this idea @cychiang, thanks for taking the initiative on it! I like the idea of having more things templated, which means that people that start...

@Argannor did you happen to have an example of what a `DeploymentRuntimeConfig` would look like that "overrides the default ports (metrics, webhook, grpc) in both `Deployment` and `Service`." You've probably...

> Unfortunately I don't have the changes in a public registry, but in a private one. I was able to build your [branch](https://github.com/Argannor/provider-kubernetes/tree/configurable-port) of `provider-kubernetes` and publish it to a...

I also tested again with `function-patch-and-transform`, with nothing else installed in the cluster. It installed and got to a healthy state, so I have to imagine that the usage of...

Also, the `check-diff` status check seems to be failing in https://github.com/crossplane/crossplane/actions/runs/11495922189/job/31996487845?pr=5540: ``` Error: Found changed files after running earthly +generate. ``` I ran `earthly +generate` locally but didn't see any...

@Argannor @ravilr great work continuing to push on this effort since the last time I reviewed. I had to focus on a few other things with the v1.18 release and...

@ravilr, thanks for the manifest provided in https://github.com/crossplane/crossplane/pull/5540#issuecomment-2597250259! To get it working, I only had to remove the quotes around `- --metrics-bind-address=":9611"`. See https://github.com/jbw976/crossplane/blob/configurable-ports-review/provider-k8s.yaml for what I got working 😉

@Argannor i'm sorry to hear you are feeling ill! I hope you recover soon 🙏 I've taken all your changes and squashed/rebased them to the latest on `main`, resolved all...

Take a look at this PR for crossplane-state-metrics, your feedback there could be helpful! * https://github.com/crossplane/crossplane/pull/6865