markdown-editor icon indicating copy to clipboard operation
markdown-editor copied to clipboard

Support Task Lists in GFM

Open Vdragon opened this issue 9 years ago • 8 comments

It seems that Task Lists still not rendered correctly.
https://github.com/blog/1375%0A-task-lists-in-gfm-issues-pulls-comments

Vdragon avatar Mar 28 '15 20:03 Vdragon

Task lists unfortunately aren't supported in chjj/marked, which is the markdown rendering library this editor uses.

That said, I'm currently working on rearranging a whole load of code and potentially switching to markdown-it as the markdown parser, which doesn't have support for task lists out-of-the-box, but it has quite a nice plugin system so I'm sure it'll be possible to add.

One question: obviously task lists will render checkboxes into the final output - would you want the ability to be able to toggle them on and off and it change the markdown source, or would you be happy with them being readonly? (obviously readonly is quite a lot easier to implement)

jbt avatar Apr 03 '15 09:04 jbt

Readonly would be fine for me.

Vdragon avatar Apr 03 '15 10:04 Vdragon

I'll see what I can do then :)

jbt avatar Apr 03 '15 10:04 jbt

Just FYI on this, after switching to markdown-it it looks like this would be very easy to do, but I don't like the available markdown-it-checkbox package (it doesn't give a nice way of applying a class to the enclosing <li>) so I'll have to see about putting something together myself. Shouldn't be too bad though.

jbt avatar Apr 15 '15 13:04 jbt

I'd like to be able to choose if I were to have a check-box or simply a graphic for the output or the ticked checkbox from font awesome.

carbontwelve avatar May 27 '15 15:05 carbontwelve

Read-only is good for me too, this would be a helpful addition.

wkoffel avatar Aug 05 '15 19:08 wkoffel

It would be really great if this feature would be supported. This is the only reason I still use GitHub markdown API instead of this project.

ooxi avatar Feb 09 '16 13:02 ooxi

I'd like to support this.

fennecdjay avatar Nov 24 '16 16:11 fennecdjay