markdown-editor icon indicating copy to clipboard operation
markdown-editor copied to clipboard

New Line break not showing up

Open ventz opened this issue 5 years ago • 3 comments

Hi,

Noticed that new-line breaks are not showing up correctly.

Ex:

1.) Cloud Flare's HTTPS DNS API:
https://developers.cloudflare.com/1.1.1.1/dns-over-https/json-format/

or

2.) Google's HTTPS DNS API:
https://developers.google.com/speed/public-dns/docs/dns-over-https

Under github this shows up as: 1.) Text 2.) Line

Where as under the markdown Editor, it shows up as: 1.) Text Line

ventz avatar Dec 01 '18 08:12 ventz

hi can you give an html that demonstrates the issue? to have some context when testing

cmnguyen01 avatar Oct 23 '19 21:10 cmnguyen01

This issue has some more discussion in #108. The problem is that Github's implementation of GFM claims to ignore the line-break but the actual implementation in the comments doesn't do that:

https://babelmark.github.io/?text=test%0Amarkdown

aero31aero avatar Oct 25 '19 16:10 aero31aero

I'm tempted to close this as WONTFIX because github's rendering and our rendering is the same in case of .md files in a repository (screenshot while editing README.md of this project):

image

We should aim to be consistent with how github treats the markdown files instead of how they treat comments on issues/PRs.

aero31aero avatar Oct 25 '19 17:10 aero31aero