node-summary icon indicating copy to clipboard operation
node-summary copied to clipboard

Work in the browser

Open jbrooksuk opened this issue 11 years ago • 5 comments

Apart from the require function being called to load lodash, there is no real reason that prevents node-summary from running in the browser.

jbrooksuk avatar Feb 11 '14 09:02 jbrooksuk

This can be implemented in the same way I've started writing Affair. It'll need a slight rewrite of the library, hopefully without breaking backwards compatibility.

jbrooksuk avatar Feb 14 '14 08:02 jbrooksuk

This has now been started and seems to work without errors, although the summarised text is different?

It currently depends on Underscore/Lo-dash however I think I could remove these dependencies by including them within the Toolkit object.

jbrooksuk avatar Feb 14 '14 09:02 jbrooksuk

I forgot to add that the test suite does pass, and it does work in the browser. Once the dependencies have been removed and the code has been improved I should be ok to merge this.

jbrooksuk avatar Feb 17 '14 07:02 jbrooksuk

Would I be able to use this as is? @jbrooksuk

oa495 avatar Feb 16 '18 19:02 oa495

I don't understand why you have to have a browser / non-browser version. Just remove summarizeFromUrl and then transpile it into es5 compatible code before packaging and that should do it.

justinmchase avatar Aug 09 '18 14:08 justinmchase